Thread (14 messages) 14 messages, 3 authors, 2021-02-23

Re: [PATCH v3 4/7] HID: lenovo: Remove lenovo_led_brightness_get()

From: Pavel Machek <hidden>
Date: 2021-02-23 09:06:15
Also in: alsa-devel, linux-input

On Sun 2021-02-21 12:20:02, Hans de Goede wrote:
The led_classdev already contains a cached value of the last set
brightness, the brightness_get callback is only meant for LED drivers
which can read back the actual / current brightness from the hardware.

Since lenovo_led_brightness_get() just returns the last set value
it does not add any functionality, so we can just remove it.

Reviewed-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Hans de Goede <redacted>
Acked-by: Pavel Machek <redacted>

-- 
http://www.livejournal.com/~pavelmachek

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help