Thread (21 messages) 21 messages, 4 authors, 2021-02-23

Re: [PATCH v2 1/7] HID: lenovo: Use brightness_set_blocking callback for setting LEDs brightness

From: Pavel Machek <hidden>
Date: 2021-02-23 09:00:46
Also in: linux-input

On Sat 2021-02-20 13:24:32, Hans de Goede wrote:
The lenovo_led_brightness_set function may sleep, so we should have the
the led_class_dev's brightness_set_blocking callback point to it, rather
then the regular brightness_set callback.

When toggle through sysfs this is not a problem, but the brightness_set
callback may be called from atomic context when using LED-triggers.

Fixes: bc04b37ea0ec ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard support")
Signed-off-by: Hans de Goede <redacted>
Acked-by: Pavel Machek <redacted>				Pavel

-- 
http://www.livejournal.com/~pavelmachek

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help