Thread (12 messages) 12 messages, 4 authors, 2021-02-19

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-02-19 14:53:01
Also in: lkml

On Fri, Feb 19, 2021 at 02:09:03PM +0000, Sven Schuchmann wrote:
quoted
Von: Andy Shevchenko [off-list ref]
Gesendet: Freitag, 19. Februar 2021 14:56
quoted
quoted
quoted
quoted
quoted
Can you or Dan submit patch getting the regulator support to work? If
not, I guess we should remove the regulator support after all.
To be true I am fairly new to the kernel and have no idea
how to test this. So no, I don't want provide a patch (except
for removing), sorry.
No problem. It seems Andy submitted series for this.
To me it seems that patches from Andy don't make
the regulator work. Maybe I am wrong?
I;m not sure I understand this correctly. Do you mean that my patches broke
something? Which one explicitly and what is broken?
No, your patches do not break something (as far as I can see).
Pavel asked for a patch to fix the regulator. The regulator
at this time is only initialized but never used in the lp50xx.
I told him (see above) that I cannot provide a patch which
fixes this. He answered that you fixed this in your series,
but to me it doesn't seem so.
or did you fix the regulator usage in your patch series?
No, I haven't touched regulator and I see now what is there.
One may add some code, I know Linus did it in many places, maybe he can help to
have done this properly?


-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help