Thread (8 messages) 8 messages, 2 authors, 2018-08-17

Re: [PATCH v4 2/2] leds: lm3697: Introduce the lm3697 driver

From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Date: 2018-08-17 19:37:14
Also in: linux-devicetree, lkml

Dan,

On 08/16/2018 10:44 PM, Dan Murphy wrote:
Jacek

On 08/16/2018 02:58 PM, Jacek Anaszewski wrote:
quoted
Dan,

Thank you for the patch.

I didn't review DT parsing details in v3, but now I've produced
diff between v3 and v4 to check what has changed.

I'm quite surprised realizing that you're not validating
HVLED and control banks assignment, having in mind earlier
discussions and your concerns about numerous DT configurations
to check.

Is it on purpose?
Yes.  It was on purpose.  After sleeping on it and going through the overall
control to HVLED assignments I realized the user will know quite quickly
that their configuration is messed up.

The suggestions actually simplified the code quite nicely which I am happier to have
Ack. Thanks for the v5 - I'll let it sit on the lists for a week anyway,
until the merge window gets closed.

-- 
Best regards,
Jacek Anaszewski
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help