On 6 August 2018 at 16:06, Pavel Machek [off-list ref] wrote:

On Mon 2018-08-06 15:33:12, Baolin Wang wrote:

quoted

Hi Pavel,

On 6 August 2018 at 15:09, Pavel Machek [off-list ref] wrote:

quoted

Hi!

quoted

quoted

In current implementation this file on read returns the number
of remaining repeat intervals. I'd add that to this description.

I saw Pavel's comments that he did not suggest do this. So I will keep
the original description?

If that is accepted, the code should return originally written number.

But I think it is more reasonable if user can know how many
repetitions were left. So for your hardware case, can we add
pattern_get() interface back to get the repetition number?

Well, I'd say that we are mostly seeing "infinite" repetitions, or one
repetition.

Yes, interface could be added to the lowlever driver -- but I'm not
sure hardware really supports getting that information; could be
tricky on N900 for example.

I'd keep it simple for now.

OK, I also like to keep it simple. I am fine the repeat file returns
originally written number. If Jacek also agrees with this, then I will
update new version.

-- 
Baolin Wang
Best Regards