Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission

From
SeongJae Park <hidden>
Date
2021-08-10 14:09:13
Also in
linux-mm, lkml, mm-commits
Reply to
Greg KH, 2021-08-10
From: SeongJae Park <redacted>

On Tue, 10 Aug 2021 13:27:44 +0200 Greg KH [off-list ref] wrote:
On Tue, Aug 10, 2021 at 11:20:50AM +0000, SeongJae Park wrote:
quoted
From: SeongJae Park <redacted>

Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
linux-mm[1] gives no execute permission to 'debugfs_attrs.sh' file.
This results in a DAMON selftest failure as below:

    $ make -C tools/testing/selftests/damon run_tests
    make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
    TAP version 13
    1..1
    # selftests: damon: debugfs_attrs.sh
    # Warning: file debugfs_attrs.sh is not executable, correct this.
    not ok 1 selftests: damon: debugfs_attrs.sh
    make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'

To solve the problem, this commit adds the execute permission for
'debugfs_attrs.sh' file.

[1] https://github.com/hnaz/linux-mm/commit/04edafbc0c07

Signed-off-by: SeongJae Park <redacted>
---
 tools/testing/selftests/damon/debugfs_attrs.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
old mode 100644
new mode 100755
-- 
2.17.1
Why not fix the tools to execute the file properly as changing the mode
of a file does not work well with all tools that we use (i.e. patch
files.)
Ok, It sounds make some sense.  Hence, I posted this patch:
https://lore.kernel.org/linux-kselftest/20210810140459.23990-1-sj38.park@gmail.com/ (local)


Thanks,
SeongJae Park

[...]
Thread (3 messages) 3 messages, 2 authors, last reply 2021-08-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help