Thread (2 messages) 2 messages, 2 authors, 2023-10-01
STALE973d

[PATCH] selftests:proc add missing field KSM in smaps_rollup[] array

From: Swarup Laxman Kotiaklapudi <hidden>
Date: 2023-09-30 12:25:39
Also in: linux-fsdevel, linux-kselftest, lkml
Subsystem: kernel selftest framework, proc filesystem, the rest · Maintainers: Shuah Khan, Linus Torvalds

Missing field KSM is added in g_smaps_rollup[] array as it
fixes assert in function test_proc_pid_smaps_rollup()

Without this patchset test fails for "proc-empty-vm" as can be seen below:
$make TARGETS="proc" kselftest
...
  selftests: proc: proc-empty-vm
  proc-empty-vm: proc-empty-vm.c:299: test_proc_pid_smaps_rollup:
   Assertion `rv == sizeof(g_smaps_rollup) - 1' failed.
  /usr/bin/timeout: the monitored command dumped core
  Aborted
  not ok 5 selftests: proc: proc-empty-vm # exit=134
...

With this patchset test passes for "proc-empty-vm" as can be seen below:
$make TARGETS="proc" kselftest
....
timeout set to 45
selftests: proc: proc-empty-vm
ok 5 selftests: proc: proc-empty-vm
....

Signed-off-by: Swarup Laxman Kotiaklapudi <redacted>
---
 tools/testing/selftests/proc/proc-empty-vm.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/proc/proc-empty-vm.c b/tools/testing/selftests/proc/proc-empty-vm.c
index b16c13688b88..ee71ce52cb6a 100644
--- a/tools/testing/selftests/proc/proc-empty-vm.c
+++ b/tools/testing/selftests/proc/proc-empty-vm.c
@@ -267,6 +267,7 @@ static const char g_smaps_rollup[] =
 "Private_Dirty:         0 kB\n"
 "Referenced:            0 kB\n"
 "Anonymous:             0 kB\n"
+"KSM:                   0 kB\n"
 "LazyFree:              0 kB\n"
 "AnonHugePages:         0 kB\n"
 "ShmemPmdMapped:        0 kB\n"
-- 
2.34.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help