Re: [PATCH] mptlan.c: fixed UNNECESSARY_CASTS warning
From: Vinesh Vilas Raut <hidden>
Date: 2021-08-21 17:34:19
On Fri, Aug 20, 2021 at 3:30 PM Lukas Bulwahn [off-list ref] wrote:
On Thu, Aug 5, 2021 at 1:12 PM Vinesh Raut [off-list ref] wrote:quoted
multiple UNNECESSARY_CASTS warnings fixed from mptlan.c
So what is casted here? from which type to which type?
From void pointer to struct sk_buff pointer.
Explain which type of bug here specifically would be hidden.
If a pointer is cast (wrongly), bugs like memory corruption, segmentation faults can occur. Also, It can affect functionality of the program.
If you do that, it is much more comprehensible and clearer why this deserves to be addressed (or not).
First , it is redundant. It will be difficult to debug. May hide Bugs if any due to (wrongly) explicit casting Regards, -Vinesh Raut _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees