Re: [PATCH v2] Documentation: checkpatch: add UNNECESSARY_CASTS message.
From: Dwaipayan Ray <dwaipayanray1@gmail.com>
Date: 2021-08-06 20:06:25
On Fri, Aug 6, 2021 at 8:49 PM Vinesh Raut [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add verbose description for UNNECESSARY_CASTS message type. Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by: Vinesh Raut <redacted> --- Documentation/dev-tools/checkpatch.rst | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst index f0956e9ea2d8..9cb6b9059fc6 100644 --- a/Documentation/dev-tools/checkpatch.rst +++ b/Documentation/dev-tools/checkpatch.rst@@ -268,6 +268,15 @@ Allocation style See: https://www.kernel.org/doc/html/latest/core-api/memory-allocation.html + **UNNECESSAR_CASTS** + Cast should not be done to any alloc functions. + Appropriate type of pointer is pick by compiler at run time
s/run time/runtime
+ Cast may hide bugs, as compiler suppress the warning after cast.
The question which arises here is what kind of bug is suppressed. Maybe follow http://c-faq.com/malloc/mallocnocast.html as checkpatch says to write up a paragraph on why it is bad.
+ + See: + 1] https://lore.kernel.org/lkml/20070808024321.GA6316@redhat.com/ (local) + 2] https://lore.kernel.org/lkml/a5e60a2b93e10baf84af063f6c8e56402273105d.camel@perches.com/ (local)
These links are just patches that introduced the test. There is not much information about "why" they were introduced. Other than that change the enumeration type to be uniform with the rest of the documentation maybe? The thing followed till now is: See: 1. link_1 2. link_2 Dwaipayan. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees