Re: [PATCH] serial: 8250_mid: Use pci_irq_vector() to get IRQ
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-08-17 12:59:20
Also in:
linux-serial, lkml
On Tue, Aug 17, 2021 at 01:44:01PM +0530, Utkarsh Verma wrote:
Instead of a direct assignment, use pci_irq_vector() to get the Linux IRQ number.
Why is this needed?
quoted hunk ↗ jump to hunk
Signed-off-by: Utkarsh Verma <redacted> --- drivers/tty/serial/8250/8250_mid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/tty/serial/8250/8250_mid.c b/drivers/tty/serial/8250/8250_mid.c index efa0515139f8..3a279ce0e904 100644 --- a/drivers/tty/serial/8250/8250_mid.c +++ b/drivers/tty/serial/8250/8250_mid.c@@ -299,7 +299,7 @@ static int mid8250_probe(struct pci_dev *pdev, const struct pci_device_id *id) memset(&uart, 0, sizeof(struct uart_8250_port)); uart.port.dev = &pdev->dev; - uart.port.irq = pdev->irq; + uart.port.irq = pci_irq_vector(pdev, 0);
What problem does this solve? Do not describe what you are doing, but rather, _why_ you are doing it. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees