On Tue, 13 Oct 2020, Joe Perches wrote:

On Wed, 2020-10-14 at 08:47 +0200, Lukas Bulwahn wrote:

quoted

On Tue, 13 Oct 2020, Joe Perches wrote:

quoted

On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote:

quoted

On Tue, 13 Oct 2020, Joe Perches wrote:

quoted

On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote:

quoted

What does checkpatch.pl warn about and what does clang-format still warn 
about, which is generally accepted okay as style in the kernel?

clang-format doesn't warn at all, it just reformats.

You can run clang-format with --dry-run and then it would just state the 
proposed changes, right?

clang-format through at least version 10 does not have
a --dry-run option.

Just a quick check:

version 9 does not have the --dry-run option:

https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormat.html

version 10 does:

https://releases.llvm.org/10.0.0/tools/clang/docs/ClangFormat.html

Perhaps some version 10 variants do, but 10.0.0 does not.

$ which clang-format
/usr/local/bin/clang-format
$ clang-format --version
clang-format version 10.0.0 (git://github.com/llvm/llvm-project.git 305b961f64b75e73110e309341535f6d5a48ed72)
$ clang-format --dry-run
clang-format: Unknown command line argument '--dry-run'.  Try: 'clang-format --help'
clang-format: Did you mean '  --debug'?

Hmm... either the documentation is wrong; or the clang-format version 
10.0.0 you are was an early version 10 during development before the 
release and did not have that feature yet? 

$ clang-format-10 --version
Ubuntu clang-format version 
10.0.1-++20200928083909+ef32c611aa2-1~exp1~20200928185400.194

$ clang-format-10 --help | grep 'dry-run'
  --dry-run                  - If set, do not actually make the formatting 
changes
  --ferror-limit=<uint>      - Set the maximum number of clang-format
    errors to emit before stopping (0 = no limit). Used only with --dry-run or -n
  -n                         - Alias for --dry-run


You have probably seen that clang/llvm-11 was released; I guess a good 
motivation for us to update our clang setup? :)

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees