On Tue, 2020-10-06 at 01:37 +0530, Dwaipayan Ray wrote:

On Tue, Oct 6, 2020 at 1:07 AM Joe Perches [off-list ref] wrote:

quoted

On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote:

quoted

The author signed-off-by checks are currently very vague.
Cases like same name or same address are not handled separately.

When you run tests for this, how many mismatches are
caused by name formatting changes like:

From: "Developer, J. Random" <redacted>
...
Signed-off-by: "J. Random Developer" <redacted>?

Should these differences generate a warning?

Hi,
I ran my tests on non merge commits between v5.7 and v5.8.

There were a total of 250 NO_AUTHOR_SIGN_OFF Warnings

203 of these were email address mismatches.
32 of these were name mismatches.

So for the name mismatches, the typical cases are like:

'From: tannerlove [off-list ref]' != 'Signed-off-by: Tanner
Love [off-list ref]'
'From: "朱灿灿" [off-list ref]' != 'Signed-off-by: zhucancan
[off-list ref]'
'From: Yuval Basson [off-list ref]' != 'Signed-off-by: Yuval
Bason [off-list ref]'
'From: allen [off-list ref]' != 'Signed-off-by: Allen Chen
[off-list ref]'

I didn't find the exact formatting change you mentioned in my commit range.
But I did find something like:

'From: "Paul A. Clarke" [off-list ref]' != 'Signed-off-by: Paul
Clarke [off-list ref]'

So it's like some have parts of their names removed, some have language
conflicts, and yet some have well different spellings, or initials,
etc. It's like
a wide variety of things happening here.

I think considering these, it should be warned about, and let people know
that there might be something wrong going on.

What do you think?

Except for comments and quotes like:

	From: J. Random Developer (BigCorp) [off-list ref]
	Signed-off-by: "J. Random Developer" [off-list ref]

I think any time there's a mismatch, there
should be a warning emitted.

That includes any subaddress detail difference.


_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees