Re: [Linux-kernel-mentees] [PATCH v3] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails
From: Joe Perches <joe@perches.com>
Date: 2020-10-03 21:35:29
Also in:
linux-usb, lkml, netdev
On Sun, 2020-10-04 at 02:49 +0530, Anant Thazhemadam wrote:
When get_registers() fails, in set_ethernet_addr(),the uninitialized value of node_id gets copied as the address. This can be considered as set_ethernet_addr() itself failing.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
[]
quoted hunk ↗ jump to hunk
@@ -909,7 +914,10 @@ static int rtl8150_probe(struct usb_interface *intf, goto out1; } fill_skb_pool(dev); - set_ethernet_addr(dev); + if (!set_ethernet_addr(dev)) { + dev_err(&intf->dev, "assigining a random MAC address\n"); + eth_hw_addr_random(dev->netdev);
4 things:
o Typo for assigning
o Reverse the assignment and message to show the new random MAC
o This should use netdev_<level>
o Is this better as error or notification?
if (!set_ethernet_addr(dev)) {
eth_hw_addr_random(dev->netdev);
netdev_notice(dev->netdev, "Assigned a random MAC: %pM\n",
dev->netdev->dev_addr);
}
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees