[Linux-kernel-mentees] checkpatch: improving comment parsing in email
From: Dwaipayan Ray <dwaipayanray1@gmail.com>
Date: 2020-10-20 17:36:05
Hi, checkpatch seems to have problems parsing some types of email comments. Some examples I could find were of the type: 1) address@example.com (Comment) 2) "Name (Comment) " address@example.com 3) address@example.com #comment These comments aren't processed currently which causes false BAD_SIGN_OFF warnings. Examples are: WARNING:BAD_SIGN_OFF: email address 'David.Laight@aculab.com (big endian system concerns)' might be better as 'David.Laight@aculab.com (big endian system concerns)' WARNING:BAD_SIGN_OFF: email address 'stable@vger.kernel.org #4.20+' might be better as 'stable@vger.kernel.org#4.20+' The earlier warning is very frequent in the kernel. I did send a patch solving (1 and 3), https://lore.kernel.org/linux-kernel-mentees/a15a6cc0ddea068d78113f5e315eaba6f52b917a.camel@perches.com/ (local) Joe points out that comments and multiple comments can exist at any part of email. (perhaps RFC 5322 Appendix A.5). So that patch didn't solve the problem at the very root. What do you recommend be done? Thanks, Dwaipayan. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees