Re: [Linux-kernel-mentees] [PATCH net] ipvs: Fix uninit-value in do_ip_vs_set_ctl()
From: Cong Wang <hidden>
Date: 2020-08-11 03:57:33
Also in:
lkml, lvs-devel, netdev, netfilter-devel
From: Cong Wang <hidden>
Date: 2020-08-11 03:57:33
Also in:
lkml, lvs-devel, netdev, netfilter-devel
On Mon, Aug 10, 2020 at 3:10 PM Peilin Ye [off-list ref] wrote:
do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is zero. Fix it.
Which exact 'cmd' is it here? I _guess_ it is one of those uninitialized in set_arglen[], which is 0. But if that is the case, should it be initialized to sizeof(struct ip_vs_service_user) instead because ip_vs_copy_usvc_compat() is called anyway. Or, maybe we should just ban len==0 case. In either case, it does not look like you fix it correctly. Thanks. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees