Thread (5 messages) 5 messages, 2 authors, 2020-08-01

Re: [Linux-kernel-mentees] [PATCH] lib: Convert test_uuid.c to KUnit

From: Brendan Higgins via Linux-kernel-mentees <hidden>
Date: 2020-07-31 20:53:48
Also in: linux-kselftest, lkml

On Fri, Jul 31, 2020 at 3:02 AM Arpitha Raghunandan [off-list ref] wrote:
On 31/07/20 11:20 am, Brendan Higgins wrote:
quoted
On Thu, Jul 30, 2020 at 5:18 AM Arpitha Raghunandan [off-list ref] wrote:
quoted
Converts test lib/test_uuid.c to KUnit
Can you add some more detail to the commit message? Maybe link to
KUnit and say something about why this change is beneficial.
Sure, I will make this change.
quoted
quoted
Signed-off-by: Arpitha Raghunandan <redacted>
Change mostly looks good to me.
Thank you for the review.
On failure, the original test calls another function which prints a detailed error. I removed it when converting to KUnit. Is this required?
I think that's probably Andy's call. Do you mind calling out the
segment of code in question?
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help