Re: [Linux-kernel-mentees] [PATCH v3] spi: spi-topcliff-pch: drop call to wakeup-disable
From: Andy Shevchenko <hidden>
Date: 2020-07-27 19:21:28
Also in:
linux-spi, lkml
On Mon, Jul 27, 2020 at 8:32 PM Vaibhav Gupta [off-list ref] wrote:
Before generic upgrade, both .suspend() and .resume() were invoking pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both states. (Normal trend is .suspend() enables and .resume() disables the wakeup.) This was ambiguous and may be buggy. Instead of replicating the legacy behavior, drop the wakeup-disable call.
Reviewed-by: Andy Shevchenko <redacted> Thanks!
quoted hunk ↗ jump to hunk
Fixes: f185bcc77980 ("spi: spi-topcliff-pch: use generic power management") Reported-by: Andy Shevchenko <redacted> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- drivers/spi/spi-topcliff-pch.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index 281a90f1b5d8..c73a03ddf5f3 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c@@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev) dev_dbg(dev, "%s ENTRY\n", __func__); - device_wakeup_disable(dev); - /* set suspend status to false */ pd_dev_save->board_dat->suspend_sts = false; --2.27.0
-- With Best Regards, Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees