Thread (14 messages) 14 messages, 5 authors, 2020-06-30

Re: [Linux-kernel-mentees] [PATCH v2 2/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors

From: Dennis Dalessandro <hidden>
Date: 2020-06-29 20:09:37
Also in: linux-pci, linux-rdma, lkml

On 6/15/2020 3:32 AM, refactormyself@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Bolarinwa Olayemi Saheed <redacted>

pcie_speeds() returns PCIBIOS_ error codes from PCIe capability accessors.

PCIBIOS_ error codes have positive values. Passing on these values is
inconsistent with functions which return only a negative value on failure.

Before passing on the return value of PCIe capability accessors, call
pcibios_err_to_errno() to convert any positive PCIBIOS_ error codes to
negative generic error values.

Suggested-by: Bjorn Helgaas <redacted>
Signed-off-by: Bolarinwa Olayemi Saheed <redacted>
---
  drivers/infiniband/hw/hfi1/pcie.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
index 1a6268d61977..eb53781d0c6a 100644
--- a/drivers/infiniband/hw/hfi1/pcie.c
+++ b/drivers/infiniband/hw/hfi1/pcie.c
@@ -306,7 +306,7 @@ int pcie_speeds(struct hfi1_devdata *dd)
  	ret = pcie_capability_read_dword(dd->pcidev, PCI_EXP_LNKCAP, &linkcap);
  	if (ret) {
  		dd_dev_err(dd, "Unable to read from PCI config\n");
-		return ret;
+		return pcibios_err_to_errno(ret);
  	}
  
  	if ((linkcap & PCI_EXP_LNKCAP_SLS) != PCI_EXP_LNKCAP_SLS_8_0GB) {
Reviewed-by: Dennis Dalessandro <redacted>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help