[Linux-kernel-mentees] [PATCH 2/2] netfilter: Pass lockdep expression to instance_lookup traversal
From: Amol Grover <hidden>
Date: 2020-02-23 17:20:26
Also in:
lkml, netdev, netfilter-devel
Subsystem:
netfilter, networking [general], the rest · Maintainers:
Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
q->instance_table[] may be traversed outside an RCU read-side critical section but under the protection of q->instances_lock. Hence, add the corresponding lockdep expression to silence false-positive lockdep warnings. Signed-off-by: Amol Grover <redacted> --- net/netfilter/nfnetlink_queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index feabdfb22920..5aef41847774 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c@@ -105,7 +105,8 @@ instance_lookup(struct nfnl_queue_net *q, u_int16_t queue_num) struct nfqnl_instance *inst; head = &q->instance_table[instance_hashfn(queue_num)]; - hlist_for_each_entry_rcu(inst, head, hlist) { + hlist_for_each_entry_rcu(inst, head, hlist, + lockdep_is_held(&q->instances_lock)) { if (inst->queue_num == queue_num) return inst; }
--
2.24.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees