Re: [Linux-kernel-mentees] [PATCH] net: core: devlink.c: Use built-in RCU list checking
From: Jiri Pirko <jiri@resnulli.us>
Date: 2020-02-21 17:20:14
Also in:
lkml, netdev
Fri, Feb 21, 2020 at 05:51:41PM CET, madhuparnabhowmik10@gmail.com wrote:
From: Madhuparna Bhowmik <redacted> list_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik <redacted>
Reviewed-by: Jiri Pirko <redacted> Thanks. However, there is a callpath where not devlink lock neither rcu read is taken: devlink_dpipe_table_register()->devlink_dpipe_table_find() I guess that was not the trace you were seeing, right?
quoted hunk ↗ jump to hunk
--- net/core/devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/net/core/devlink.c b/net/core/devlink.c index 4c63c9a4c09e..3e8c94155d93 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c@@ -2107,7 +2107,8 @@ devlink_dpipe_table_find(struct list_head *dpipe_tables,{ struct devlink_dpipe_table *table; - list_for_each_entry_rcu(table, dpipe_tables, list) { + list_for_each_entry_rcu(table, dpipe_tables, list, + lockdep_is_held(&devlink->lock)) { if (!strcmp(table->name, table_name)) return table; } -- 2.17.1
_______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees