Re: [PATCH v2 04/13] kbuild: factor out OBJECT_FILES_NON_STANDARD check into a macro

[PATCH v2 00/13] kbuild: second round of Clang LTO refactoring · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
[PATCH v2 03/13] kbuild: store the objtool command in *.cmd files · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files · Nick Desaulniers <ndesaulniers@google.com> · 2021-08-31
Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files · Josh Poimboeuf <hidden> · 2021-09-04
Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files · Josh Poimboeuf <hidden> · 2021-09-04
Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files · Masahiro Yamada <masahiroy@kernel.org> · 2021-09-08
[PATCH v2 09/13] kbuild: add cmd_and_savecmd macro · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 09/13] kbuild: add cmd_and_savecmd macro · Kees Cook <hidden> · 2021-08-31
[PATCH v2 07/13] kbuild: do not create built-in.a.symversions or lib.a.symversions · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 07/13] kbuild: do not create built-in.a.symversions or lib.a.symversions · Kees Cook <hidden> · 2021-08-31
[PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION · Masahiro Yamada <masahiroy@kernel.org> · 2021-09-03
Re: [PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION · Nick Desaulniers <ndesaulniers@google.com> · 2021-08-31
Re: [PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION · Masahiro Yamada <masahiroy@kernel.org> · 2021-09-02
Re: [PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION · Josh Poimboeuf <hidden> · 2021-09-04
[PATCH v2 02/13] kbuild: rename __objtool_obj to objtool · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 02/13] kbuild: rename __objtool_obj to objtool · Nick Desaulniers <ndesaulniers@google.com> · 2021-08-31
Re: [PATCH v2 02/13] kbuild: rename __objtool_obj to objtool · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 02/13] kbuild: rename __objtool_obj to objtool · Josh Poimboeuf <hidden> · 2021-09-04
[PATCH v2 10/13] kbuild: rebuild modules when objtool is updated for CONFIG_LTO_CLANG · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 10/13] kbuild: rebuild modules when objtool is updated for CONFIG_LTO_CLANG · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 10/13] kbuild: rebuild modules when objtool is updated for CONFIG_LTO_CLANG · Josh Poimboeuf <hidden> · 2021-09-04
[PATCH v2 04/13] kbuild: factor out OBJECT_FILES_NON_STANDARD check into a macro · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 04/13] kbuild: factor out OBJECT_FILES_NON_STANDARD check into a macro · Nick Desaulniers <ndesaulniers@google.com> · 2021-08-31
Re: [PATCH v2 04/13] kbuild: factor out OBJECT_FILES_NON_STANDARD check into a macro · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 04/13] kbuild: factor out OBJECT_FILES_NON_STANDARD check into a macro · Josh Poimboeuf <hidden> · 2021-09-04
[PATCH v2 06/13] kbuild: reuse $(cmd_objtool) for cmd_cc_lto_link_modules · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 06/13] kbuild: reuse $(cmd_objtool) for cmd_cc_lto_link_modules · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 06/13] kbuild: reuse $(cmd_objtool) for cmd_cc_lto_link_modules · Masahiro Yamada <masahiroy@kernel.org> · 2021-09-03
Re: [PATCH v2 06/13] kbuild: reuse $(cmd_objtool) for cmd_cc_lto_link_modules · Kees Cook <hidden> · 2021-09-03
Re: [PATCH v2 06/13] kbuild: reuse $(cmd_objtool) for cmd_cc_lto_link_modules · Josh Poimboeuf <hidden> · 2021-09-04
[PATCH v2 01/13] kbuild: move objtool_args back to scripts/Makefile.build · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 01/13] kbuild: move objtool_args back to scripts/Makefile.build · Josh Poimboeuf <hidden> · 2021-09-04
[PATCH v2 08/13] kbuild: build modules in the same way with/without Clang LTO · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
Re: [PATCH v2 08/13] kbuild: build modules in the same way with/without Clang LTO · Kees Cook <hidden> · 2021-08-31
Re: [PATCH v2 08/13] kbuild: build modules in the same way with/without Clang LTO · Nick Desaulniers <ndesaulniers@google.com> · 2021-08-31
[PATCH v2 13/13] kbuild: merge cmd_ar_builtin and cmd_ar_module · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
[PATCH v2 11/13] kbuild: always postpone CRC links for module versioning · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31
[PATCH v2 12/13] kbuild: merge cmd_modversions_c and cmd_modversions_S · Masahiro Yamada <masahiroy@kernel.org> · 2021-08-31

From: Kees Cook <hidden>
Date: 2021-08-31 17:31:14
Also in: lkml

On Tue, Aug 31, 2021 at 04:39:55PM +0900, Masahiro Yamada wrote:

The OBJECT_FILES_NON_STANDARD check is quite long.

Factor it out into a new macro, objtool-enabled, to not repeat it.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Looks right to me.

Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help