Thread (11 messages) 11 messages, 3 authors, 2021-09-07

Re: [PATCH] Makefile: use -Wno-main in the full kernel tree

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-08-16 15:09:05
Also in: lkml

On Fri, 13 Aug 2021 15:41:31 -0700
Randy Dunlap [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When using gcc (SUSE Linux) 7.5.0 (on openSUSE 15.3), I see a
build warning:

../kernel/trace/trace_osnoise.c: In function 'start_kthread':
../kernel/trace/trace_osnoise.c:1461:8: warning: 'main' is usually a function [-Wmain]
  void *main = osnoise_main;
        ^~~~

Quieten that warning by using "-Wno-main". It's OK to use "main" as a
declaration name in the kernel.

Build-tested on most ARCHes.

Signed-off-by: Randy Dunlap <redacted>
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <redacted>
Cc: linux-kbuild@vger.kernel.org
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20210812.orig/Makefile
+++ linux-next-20210812/Makefile
@@ -522,7 +522,7 @@ KBUILD_AFLAGS   := -D__ASSEMBLY__ -fno-P
 KBUILD_CFLAGS   := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
 		   -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
 		   -Werror=implicit-function-declaration -Werror=implicit-int \
-		   -Werror=return-type -Wno-format-security \
+		   -Werror=return-type -Wno-format-security -Wno-main \
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve
 		   -std=gnu89
 KBUILD_CPPFLAGS := -D__KERNEL__
 KBUILD_RUST_TARGET := $(srctree)/arch/$(SRCARCH)/rust/target.json
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help