Re: [PATCH] scripts: Fix incremental build header re-generation
From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2021-03-02 08:12:07
Also in:
lkml
On Mon, Mar 1, 2021 at 11:23 PM Jeevan Shriram [off-list ref] wrote:
compile.h and autoconf.h are ignored when checking headers sha as they are always re-generated for every kernel compilation. However, these two headers are packaged into kheaders tar. During incremental compilation of kernel, kheaders tar file is always generated and re-packaged irrespective of the changes in headers.
I do not see this problem. Could you describe the steps to reproduce it, please?
quoted hunk ↗ jump to hunk
Change-Id: I7a64faebb81df44c32230b0fea1d6df09d7ce66f Signed-off-by: Jeevan Shriram <redacted> --- kernel/gen_kheaders.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh index c1510f0..5499f72 100755 --- a/kernel/gen_kheaders.sh +++ b/kernel/gen_kheaders.sh@@ -51,8 +51,7 @@ this_file_md5="$(ls -l $sfile | md5sum | cut -d ' ' -f1)" if [ -f $tarfile ]; then tarfile_md5="$(md5sum $tarfile | cut -d ' ' -f1)"; fi if [ -f kernel/kheaders.md5 ] && [ "$(head -n 1 kernel/kheaders.md5)" = "$headers_md5" ] && - [ "$(head -n 2 kernel/kheaders.md5 | tail -n 1)" = "$this_file_md5" ] && - [ "$(tail -n 1 kernel/kheaders.md5)" = "$tarfile_md5" ]; then + [ "$(head -n 2 kernel/kheaders.md5 | tail -n 1)" = "$this_file_md5" ]; then exit fi --The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
-- Best Regards Masahiro Yamada