Thread (31 messages) 31 messages, 6 authors, 2021-02-08

Re: module loader dead code removal and cleanups v3

From: Emil Velikov <hidden>
Date: 2021-02-02 17:42:24
Also in: dri-devel, linuxppc-dev, live-patching, lkml

Hi Jessica,

On Tue, 2 Feb 2021 at 14:37, Jessica Yu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+++ Christoph Hellwig [02/02/21 13:13 +0100]:
quoted
Hi all,

this series removes support for long term unused export types and
cleans up various loose ends in the module loader.

Changes since v2:
- clean up klp_find_object_symbol a bit
- remove the now unused module_assert_mutex helper

Changes since v1:
- move struct symsearch to module.c
- rework drm to not call find_module at all
- allow RCU-sched locking for find_module
- keep find_module as a public API instead of module_loaded
- update a few comments and commit logs
Thanks Christoph for cleaning up all that aged cruft, and thanks everyone
for the reviews.

I was curious about EXPORT_SYMBOL_GPL_FUTURE and EXPORT_UNUSED_SYMBOL
variants, and found that most of that stuff was introduced between
2006 - 2008. All the of the unused symbols were removed and gpl future
symbols were converted to gpl quite a long time ago, and I don't
believe these export types have been used ever since. So I
think it's safe to retire those export types now.
I believe you're spot on - based on reading through git log and
checking the ML archives.

Shame I didn't get to finish a similar series I had locally. Patches
11-13 match what I have here so:
Reviewed-by: Emil Velikov <redacted>

HTH
-Emil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help