Re: [PATCH 03/13] livepatch: refactor klp_init_object
From: Petr Mladek <pmladek@suse.com>
Date: 2021-01-27 13:00:53
Also in:
dri-devel, linuxppc-dev, live-patching, lkml
On Thu 2021-01-21 08:49:49, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
Merge three calls to klp_is_module (including one hidden inside klp_find_object_module) into a single one to simplify the code a bit. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/livepatch/core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index f76fdb9255323d..a7f625dc24add3 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c@@ -54,9 +54,6 @@ static void klp_find_object_module(struct klp_object *obj) { struct module *mod; - if (!klp_is_module(obj)) - return; -
We need to either update the function description or keep this check. I prefer to keep the check. The function does the right thing also for the object "vmlinux". Also the livepatch code includes many similar paranoid checks that makes the code less error prone against any further changes. Of course, it is a matter of taste.
mutex_lock(&module_mutex); /* * We do not want to block removal of patched modules and therefore
Otherwise, the patch looks fine. Best Regards, Petr