Re: [PATCH] bpf: Hoise pahole version checks into Kconfig
From: Nathan Chancellor <hidden>
Date: 2021-01-14 02:03:11
Also in:
bpf, lkml, netdev
On Wed, Jan 13, 2021 at 02:38:27PM -0800, Andrii Nakryiko wrote:
Hm.. Just saw Linus proposing using $(error-if) in Kconfig for an unrelated issue ([0]). If we can make this work, then it would catch such issue early on, yet won't have any downsides of hiding CONFIG_DEBUG_INFO_BTF if pahole is too old. WDYT? [0] https://lore.kernel.org/lkml/CAHk-=wh-+TMHPTFo1qs-MYyK7tZh-OQovA=pP3=e06aCVp6_kA@mail.gmail.com/ (local)
Yes, I think that would be exactly what we want because DEBUG_INFO_BTF could cause the build to error if PAHOLE_VERSION is not >= 116. I will try to keep an eye on that thread to see how it goes then respin this based on anything that comes from it. Cheers, Nathan