Re: Regression in "kbuild: fix if_change and friends to consider argument order"
From: Michal Marek <hidden>
Date: 2016-06-27 20:10:21
Also in:
lkml
Dne 26.6.2016 v 12:43 Thorsten Leemhuis napsal(a):
On 09.06.2016 01:29, Zanoni, Paulo R wrote:quoted
Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu:quoted
On Tue, Jun 07, 2016 at 02:10:28PM +0000, Zanoni, Paulo R wrote: From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00 2001 From: Michal Marek <redacted> Date: Tue, 7 Jun 2016 11:57:02 +0200 Subject: [PATCH] kbuild: Initialize exported variables The NOSTDINC_FLAGS variable is exported, so it needs to be cleared to avoid duplicating its content when running make from within make (e.g. in the packaging targets). This became an issue after commit 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument order"), which no longer ignores the duplicate options. As Paulo Zanoni points out, the LDFLAGS_vmlinux variable has the same problem. Reported-by: "Zanoni, Paulo R" <redacted> Fixes: 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument order") Signed-off-by: Michal Marek <redacted>Works for me. Tested-by: Paulo Zanoni <redacted>Michal, what's the status here? This made it on my 4.7 regressions report due to the "regression" keyword in the subject.
I forgot to send it to Linus, fixed now. Thanks for the reminder. Michal