Re: [Patch] scripts: fix "make install" when a directory or file named install exists
From: Michal Marek <hidden>
Date: 2012-08-30 13:30:57
On 7.8.2012 11:08, Andrew Worsley wrote:
quoted hunk ↗ jump to hunk
diff --git a/scripts/Makefile.build b/scripts/Makefile.build index ff1720d..cf4b970 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build@@ -434,6 +434,7 @@ $(multi-used-m) : %.o: $(multi-objs-m) FORCE targets += $(multi-used-y) $(multi-used-m) +PHONY += install # Descending # ---------------------------------------------------------------------------
I don't think this is the right place to fix it (at least, it should be near the .PHONY target with an explanation why it is needed). First, the PHONY variable is usually assigned right before the target is defined. Second, the are usually two 'install' targets: One is in arch/$arch/Makefile, which usually invokes scripts/Makefile.build in arch/$arch/boot, where the actual install target is defined. So this patch only covers the arch/$arch/boot/Makefile case. It works on x86, because arch/x86/Makefile already has the PHONY assignment and only arch/x86/boot/Makefile is missing it. Also, not all architectures have install, while some have more *install variants. So I'm for fixing the Makefiles that do not yet have the PHONY += install or such. Michal