Re: [PATCH 6/6] i2c: Make remove callback return void
From: Jean Delvare <hidden>
Date: 2022-07-05 10:09:00
Also in:
alsa-devel, chrome-platform, dri-devel, linux-arm-kernel, linux-clk, linux-crypto, linux-devicetree, linux-fbdev, linux-gpio, linux-hwmon, linux-i2c, linux-iio, linux-input, linux-leds, linux-media, linux-mediatek, linux-omap, linux-pm, linux-pwm, linux-rtc, linux-serial, linux-staging, linux-usb, linux-watchdog, linuxppc-dev, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2022-07-06 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
- 2022-07-06 · Re: [PATCH 6/6] i2c: Make remove callback return void · Vladimir Oltean <olteanv@gmail.com>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Luca Ceresoli <luca@lucaceresoli.net>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Maximilian Luz <luzmaximilian@gmail.com>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-König wrote:
From: Uwe Kleine-König <redacted> The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Signed-off-by: Uwe Kleine-König <redacted> ---
That's a huge change for a relatively small benefit, but if this is approved by the I2C core maintainer then fine with me. For:
drivers/hwmon/adc128d818.c | 4 +--- drivers/hwmon/adt7470.c | 3 +-- drivers/hwmon/asb100.c | 6 ++---- drivers/hwmon/asc7621.c | 4 +--- drivers/hwmon/dme1737.c | 4 +--- drivers/hwmon/f75375s.c | 5 ++--- drivers/hwmon/fschmd.c | 6 ++---- drivers/hwmon/ftsteutates.c | 3 +-- drivers/hwmon/ina209.c | 4 +--- drivers/hwmon/ina3221.c | 4 +--- drivers/hwmon/jc42.c | 3 +-- drivers/hwmon/mcp3021.c | 4 +--- drivers/hwmon/occ/p8_i2c.c | 4 +--- drivers/hwmon/pcf8591.c | 3 +-- drivers/hwmon/smm665.c | 3 +-- drivers/hwmon/tps23861.c | 4 +--- drivers/hwmon/w83781d.c | 4 +--- drivers/hwmon/w83791d.c | 6 ++---- drivers/hwmon/w83792d.c | 6 ++---- drivers/hwmon/w83793.c | 6 ++---- drivers/hwmon/w83795.c | 4 +--- drivers/hwmon/w83l785ts.c | 6 ++---- drivers/i2c/i2c-core-base.c | 6 +----- drivers/i2c/i2c-slave-eeprom.c | 4 +--- drivers/i2c/i2c-slave-testunit.c | 3 +-- drivers/i2c/i2c-smbus.c | 3 +-- drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +--
Reviewed-by: Jean Delvare <redacted> -- Jean Delvare SUSE L3 Support