Re: [PATCH 5/5] spi: make remove callback a void function
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2022-01-25 10:24:12
Also in:
alsa-devel, dri-devel, linux-can, linux-clk, linux-fbdev, linux-gpio, linux-hwmon, linux-iio, linux-input, linux-leds, linux-media, linux-mmc, linux-omap, linux-rtc, linux-serial, linux-spi, linux-staging, linux-usb, linux-wireless, lkml, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2022-03-02 · Re: [PATCH 5/5] spi: make remove callback a void function · Pavel Machek <hidden>
- 2022-02-18 · Re: [PATCH 5/5] spi: make remove callback a void function · Hans Verkuil <hidden>
- 2022-02-08 · Re: [PATCH 5/5] spi: make remove callback a void function · Mark Brown <broonie@kernel.org>
- 2022-01-25 · Re: [PATCH 5/5] spi: make remove callback a void function · Geert Uytterhoeven <geert@linux-m68k.org>
- 2022-01-25 · Re: [PATCH 5/5] spi: make remove callback a void function · Uwe Kleine-König <hidden>
Hi Uwe, u.kleine-koenig@pengutronix.de wrote on Sun, 23 Jan 2022 18:52:01 +0100:
The value returned by an spi driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Signed-off-by: Uwe Kleine-König <redacted> ---
[...]
drivers/mtd/devices/mchp23k256.c | 4 +--- drivers/mtd/devices/mchp48l640.c | 4 +--- drivers/mtd/devices/mtd_dataflash.c | 4 +--- drivers/mtd/devices/sst25l.c | 4 +---
For MTD devices: Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl