Re: [PATCH v4 01/14] x86/boot: Fix memremap of setup_indirect structures

From
Daniel Kiper <hidden>
Date
2021-09-22 12:02:38
Also in
linux-doc, linux-iommu, lkml
Reply to
Ross Philipson, 2021-08-27
On Fri, Aug 27, 2021 at 09:28:24AM -0400, Ross Philipson wrote:
As documented, the setup_indirect structure is nested inside
the setup_data structures in the setup_data list. The code currently
accesses the fields inside the setup_indirect structure but only
the sizeof(struct setup_data) is being memremapped. No crash
occured but this is just due to how the area is remapped under the
covers.

The fix is to properly memremap both the setup_data and setup_indirect
structures in these cases before accessing them.

Fixes: b3c72fc9a78e ("x86/boot: Introduce setup_indirect")

Signed-off-by: Ross Philipson <redacted>
Reviewed-by: Daniel Kiper <redacted>

This is the fix. So, I think it should be taken now, regardless of the
fate of the other patches in the series.

Daniel
Thread (28 messages) 28 messages, 6 authors, last reply 2022-02-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help