Thread (6 messages) 6 messages, 4 authors, 2021-09-13

Re: [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor check

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-09-13 20:31:19
Also in: lkml

On Mon, 2021-09-13 at 14:05 +0200, Florian Eckert wrote:
On my embedded system I use this tpm infineon chip via i2c bus.
The system is a MIPS architecture and therefore works in big endian mode.

The problem is, that the chip type is not correctly recognized,
because the vendor ID is wrongly aligned in the memory.

By declaring the vendor ID variable as a `__le32` type, the TPM chip is
then correctly recognized by the driver and feels then responsible.
Please no hyphens just normal single quotes.

You should have always in a commit message some explanation what
the patch does in imperative form, e.g. "Change type of xxx ...
because ...".

I cannot from find a variable named "vendor ID" from
tpm_tis_i2c_init(). Maybe you are referring to the variable,
of which name is "vendor"?

Finally, the commit message lacks explanation what is changed, i.e.
tpm2_tis_i2c_init() in this case.

Did you find the commit ID where this regression was introduceD?

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help