Thread (8 messages) 8 messages, 4 authors, 2021-07-30

Re: [PATCH] tpm: ibmvtpm: Avoid error message when process gets signal while waiting

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-07-28 21:50:38
Also in: linux-security-module, lkml

On Mon, Jul 26, 2021 at 11:00:51PM -0400, Stefan Berger wrote:
On 7/26/21 10:42 PM, Jarkko Sakkinen wrote:
quoted
On Mon, Jul 12, 2021 at 12:25:05PM -0400, Stefan Berger wrote:
quoted
From: Stefan Berger <stefanb@linux.ibm.com>

When rngd is run as root then lots of these types of message will appear
in the kernel log if the TPM has been configure to provide random bytes:

[ 7406.275163] tpm tpm0: tpm_transmit: tpm_recv: error -4

The issue is caused by the following call that is interrupted while
waiting for the TPM's response.

sig = wait_event_interruptible(ibmvtpm->wq,
                                !ibmvtpm->tpm_processing_cmd);

The solution is to use wait_event() instead.
Why?
So it becomes uninterruptible and these error messages go away.
We do not want to make a process uninterruptible. That would prevent
killing it.

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help