Thread (4 messages) 4 messages, 3 authors, 2021-05-03

Re: [PATCH] KEYS: trusted: Fix memory leak on object td

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-05-03 14:53:54
Also in: kernel-janitors, keyrings, linux-security-module, lkml

On Fri, Apr 30, 2021 at 12:37:24PM +0100, Colin King wrote:
From: Colin Ian King <redacted>

Two error return paths are neglecting to free allocated object td,
causing a memory leak. Fix this by returning via the error return
path that securely kfree's td.

Fixes clang scan-build warning:
security/keys/trusted-keys/trusted_tpm1.c:496:10: warning: Potential
memory leak [unix.Malloc]

Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
Signed-off-by: Colin Ian King <redacted>
 
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help