Re: [PATCH v2] tpm_crb: Use IOMEM_ERR_PTR when function returns iomem
From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-05-03 14:50:16
On Thu, Apr 29, 2021 at 03:39:39PM +0800, Tian Tao wrote:
This is to simplify the code, and IOMEM_ERR_PTR(err) is same with (__force void __iomem *)ERR_PTR(err). Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> /Jarkko
quoted hunk ↗ jump to hunk
--- v2: rewrite the commit message. --- drivers/char/tpm/tpm_crb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index a9dcf31..1860665 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c@@ -464,7 +464,7 @@ static void __iomem *crb_map_res(struct device *dev, struct resource *iores, /* Detect a 64 bit address on a 32 bit system */ if (start != new_res.start) - return (void __iomem *) ERR_PTR(-EINVAL); + return IOMEM_ERR_PTR(-EINVAL); if (!iores) return devm_ioremap_resource(dev, &new_res);-- 2.7.4