Thread (10 messages) 10 messages, 2 authors, 2021-05-31

Re: [PATCH v2 1/7] crypto: fix a memory leak in sm2

From: hongbo li <hidden>
Date: 2021-05-31 12:43:34
Also in: keyrings, linux-crypto, lkml

Tianjia Zhang [off-list ref] 于2021年5月28日周五 下午2:27写道:
Hi Herbert, Hongbo,

On 5/27/21 9:53 PM, Hongbo Li wrote:
quoted
From: Hongbo Li <redacted>

SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
test_akcipher_one(), it will set public key for every test vector,
and don't free ec->Q. This will cause a memory leak.

This patch alloc ec->Q in sm2_ec_ctx_init().

Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
Signed-off-by: Hongbo Li <redacted>
Reviewed-by: Tianjia Zhang <redacted>
---
  crypto/sm2.c | 24 ++++++++++--------------
  1 file changed, 10 insertions(+), 14 deletions(-)
Patch 1/7 is an independent bugfix patch. If possible, consider applying
it first.

The commit message header should start with: crypto: sm2 -

Also added:

Cc: stable@vger.kernel.org # v5.10+

Best regards,
Tianjia
OK, will send this patch later.

Regards,
Hongbo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help