On Wed, May 12, 2021 at 09:12:26AM +0800, Leizhen (ThunderTown) wrote:

On 2021/5/10 4:41, Jarkko Sakkinen wrote:

quoted

On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:

quoted

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Zhen Lei <redacted>

In the commit message:

1. Instead of writing "a negative error code", write -EFAULT.

OK, I will change it.

quoted

2. Some explanation of the choice.

Do you mean why I choice error code -EFAULT? There's a similar one above this branch.

        if (nr_commands > 0xFFFFF) {
                rc = -EFAULT;
                goto out;
        }

I mean that the commit message must rationalize whatever the commit does,
and choices made.

/Jarkko