On Fri, Feb 05, 2021 at 04:04:18AM +0200, Jarkko Sakkinen wrote:

On Thu, Feb 04, 2021 at 10:54:27PM +0100, Rikard Falkeborn wrote:

quoted

The only usage of ppi_attr_grp is to put its address in an array of
pointers to const struct attribute_group. Make it const to allow the
compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <redacted>

Thanks.

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko

Hi Jarkko,
I saw this was merged as commit
90cba8d20f8b09d62a25f9864cb8e67722d76c3a, but in the commit, there was an
additional change where a call to dump_stack() was added in
drivers/char/tpm/tpm-chip.c, was this intentional?

/Rikard