Re: [PATCH v2 1/3] add params and ids to support nist_p384
From: Saulo Alessandre de Lima <hidden>
Date: 2021-02-24 14:51:49
Also in:
keyrings, linux-crypto, lkml
From: Saulo Alessandre de Lima <hidden>
Date: 2021-02-24 14:51:49
Also in:
keyrings, linux-crypto, lkml
Em seg., 22 de fev. de 2021 às 17:26, Stefan Berger [off-list ref] escreveu:
On 2/22/21 12:58 PM, Saulo Alessandre wrote:quoted
From: Saulo Alessandre <redacted> * crypto/asymmetric_keys/x509_cert_parser.c - prepare x509 parser to load nist_secp384r1 * crypto/ecc_curve_defs.h - add nist_p384 params * include/crypto/ecdh.h - add ECC_CURVE_NIST_P384 * include/linux/oid_registry.h - reorder OID_id_ecdsa_with_sha1 - add OID_id_secp384r1 Signed-off-by: Saulo Alessandre <redacted>I would separate this patch into an x509: and certs: part since it touches two subsystems. I can take this series of patches and post my v9 including them at the end. This would make it easier for others to test. I would massage them a bit, including the separation of the 1st patch into 2 patches, if you don't mind, preserving your Signed-off-by. I need to fix something in my v8 regarding registration failure handling. Let me know whether this is fine with you.
For me it's ok.
I had tested your patches over the weekend with my endless test tool
creating keys in user space and loading them into the kernel. It worked
fine for NIST p256 & p384. Also signing kernel modules with NIST p384 is
working fine.
So, for the series:
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
Regards,
Stefan
Regards -- []'s ----- Saulo Alessandre [off-list ref]