Thread (29 messages) 29 messages, 5 authors, 2021-02-03

Re: [PATCH v4] tpm_tis: Add missing tpm_request/relinquish_locality calls

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-02-02 21:50:43
Also in: lkml

On Tue, Feb 02, 2021 at 08:57:24PM +0100, Lukasz Majczak wrote:
There are missing calls to tpm_request_locality before the calls to
the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions
internally send commands to the tpm. As the current
approach might work for tpm2, it fails for tpm1.x - in that case
call to tpm_get_timeouts() or tpm_tis_probe_irq_single()
without acquired locality fails and in turn causes tpm_tis_core_init()
to fail, it can be observed in the log with the following warning
trace:
Ignoring this version.

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help