On Tue, Feb 16, 2021 at 06:26:54PM +0200, Jarkko Sakkinen wrote:

On Tue, Feb 16, 2021 at 06:16:58PM +0200, Jarkko Sakkinen wrote:

quoted

On Tue, Feb 16, 2021 at 12:02:24PM +0100, Laurent Bigonville wrote:

quoted

Le 16/02/21 à 09:17, Jarkko Sakkinen a écrit :

quoted

From: Lukasz Majczak <redacted>

This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2
(SLB 9670):

[    4.324298] TPM returned invalid status
[    4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f

Background
==========

TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO
Interface Locality Usage per Register, Table 39 Register Behavior Based on
Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns
0xFF in case of lack of locality. The described situation manifests itself
with the following warning trace:

The fix
=======

Add the proper decorations to tpm_tis_gen_interrupt() and
tpm_get_timeouts().

I tried that patch (alone on the top of the HEAD of Linus master) and I
still get the same trace in dmesg

Can you give a shot to

git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git

It has couple of more fixes, and paste the log.

And if possible a full stack trace :-)

And apply this patch on top. Cannot apply it there before it's reviewed.

/Jarkko