Re: [PATCH v5 11/42] namei: make permission helpers idmapped mount aware

From
Christoph Hellwig <hch@infradead.org>
Date
2021-01-19 22:56:09
Also in
linux-api, linux-ext4, linux-fsdevel, linux-security-module, linux-xfs, selinux
Reply to
Christian Brauner, 2021-01-12
On Tue, Jan 12, 2021 at 11:00:53PM +0100, Christian Brauner wrote:
The two helpers inode_permission() and generic_permission() are used by
the vfs to perform basic permission checking by verifying that the
caller is privileged over an inode. In order to handle idmapped mounts
we extend the two helpers with an additional user namespace argument.
On idmapped mounts the two helpers will make sure to map the inode
according to the mount's user namespace and then peform identical
permission checks to inode_permission() and generic_permission(). If the
initial user namespace is passed nothing changes so non-idmapped mounts
will see identical behavior as before.
More long lines in here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Thread (79 messages) 79 messages, 7 authors, last reply 2021-01-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help