Re: [PATCH v5 1/2] tpm: add sysfs exports for all banks of PCR registers
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2021-01-15 17:27:12
Also in:
linux-api
On Fri, 2021-01-15 at 14:54 +0100, Greg KH wrote:
On Thu, Jan 14, 2021 at 04:21:08PM -0800, James Bottomley wrote:
[...]
quoted
It looks like we already have a couple of bugs in the kernel introduced by this confusion ... return sysfs_emit() vs return sysfs_emit_at() being the most tricky ...Hm, Joe, you did the conversion to these functions (and wrote the api), care to review this?
A cursory glance tells me that summary_show in drivers/infiniband/hw/usnic/usnic_ib_sysfs.c has a problem, I think the last = should be += James