Hi Mimi,

...

Thanks!  I made minor changes as noted below.  A subsequent patch
makes a similar change for the new TPM 1.2 PCRs.

+1 to all the changes. I guess you haven't pushed it yet.


Kind regards,
Petr

quoted

 src/evmctl.c | 7 +++++++
 1 file changed, 7 insertions(+)

quoted

diff --git a/src/evmctl.c b/src/evmctl.c
index 04dc2ad..3ad5039 100644
--- a/src/evmctl.c
+++ b/src/evmctl.c

@@ -2082,6 +2082,13 @@ static int read_binary_bios_measurements(char *file, struct tpm_bank_info *bank)
 	int len;
 	int i;

quoted

+	struct stat s;
+	stat(file, &s);

Checked stat return code.

quoted

+	if (!S_ISREG(s.st_mode)) {
+		log_errno("Not a regular file or link to regular file.\n");

Prefixed message with "Bios event log: not ..."

...