On 12/5/2018 1:14 AM, Jarkko Sakkinen wrote:

On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote:

quoted

The new tpm_bank_list structure has been preferred to the tpm_digest
structure, to let the caller specify the size of the digest (which may be
unknown to the TPM driver).

Why is that? Didn't previous commit query these?

quoted

+struct tpm_bank_list {
+	u16 alg_id;
+	u16 extend_size;
+	const u8 *extend_array;
+};

Naming is not good here. If this only for extending shouldn't that
be in the structs name?

tpm_extend_input?

Roberto

/Jarkko

-- 
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI