Thread (29 messages) 29 messages, 6 authors, 2018-03-10

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

From: Winkler, Tomas <hidden>
Date: 2018-03-05 18:05:03
Also in: linux-security-module, lkml

On Mon, Mar 05, 2018 at 01:09:09PM +0000, Winkler, Tomas wrote:
quoted
quoted
enum tpm_duration {
	TPM_DURATION_DEFAULT = 2000,
	TPM_DURATION_LONG = 300000,
};
How is this aligned with the spec PTP spec?
For TPM 2.0 that spec only partially defines durations for CCs and thus our
look up table is already kind "flakky". In a sense that the default duration is
upper limit for spec defined durations.
The timeouts for LONG and MEDIUM is defined by the  PTP spec,  we need to maintain those as those effect the system.
The UNDEFINED and LONG LONG is the implementation choice we driver from empirical data we have so far.
quoted
quoted
These would be both for TPM 1.2 and TPM 2.0. Instead of having table
for every ordinal there should be a small tables describing commands
that require long timeout.
Yeah I didn't cover the 1.2.
I could probably help with TPM 1.2 changes if required.
In middle of it, will send for review in few.

Thanks
Tomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help