On Tue, Mar 27, 2018 at 12:07:14AM +0000, Sahil Rihan wrote:

quoted

On 3/22/18, 7:20 AM, "Jarkko Sakkinen" [off-list ref] wrote:

  On Tue, 2018-03-20 at 22:29 +0000, Sahil Rihan wrote:
  > > On 3/19/18, 2:25 PM, "Jarkko Sakkinen" [off-list ref]
  > > wrote:
  > >     
  > >    Sahil, would you care to try if this fixes the issue that you are
  > >    having or not?
  > 
  > Yes, we can test this out. Might take a day or two.
   
  Awesome, thank you. I'll add
   
  Reported-by: Sahil Rihan [off-list ref]
   
  if that is OK for you?

Jarkko, 

We applied your patch to a 4.11 kernel (unfortunately not the latest upstream) and were able to confirm that the char device is now being created correctly. The sysfs enabled node is also present.

And yes, please add the "Reported-by" line.

Thanks,
Sahil

And also

Tested-by: Sahil Rihan <redacted>

?

/Jarkko