Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()
From: Jason Gunthorpe <hidden>
Date: 2017-10-25 15:22:45
Also in:
keyrings, linux-crypto, linux-security-module, lkml
On Wed, Oct 25, 2017 at 01:55:04PM +0200, Jarkko Sakkinen wrote:
Device number (the character device index) is not a stable identifier for a TPM chip. That is the reason why every call site passes TPM_ANY_NUM to tpm_chip_find_get(). This commit changes the API in a way that instead a struct tpm_chip instance is given and NULL means the default chip. In addition, this commit refines the documentation to be up to date with the implementation. Suggested-by: Jason Gunthorpe <redacted> (@chip_num -> @chip) Signed-off-by: Jarkko Sakkinen <redacted> v2: * Further defined function documentation. * Changed @chip_num to @chip instead of removing the parameter as suggested by Jason Gunthorpe.
Reviewed-by: Jason Gunthorpe <redacted> Jason