Re: [PATCH v4 03/16] HID: ft260: add GPIO support

From
Michael Zaidman <michael.zaidman@gmail.com>
Date
2026-11-18 20:57:01
Also in
linux-gpio, linux-serial, sashiko-reviews
Reply to
sashiko-bot@kernel.org, 2026-11-17
On Tue, Nov 17, 2026 at 08:23:52PM +0000, sashiko-bot@kernel.org wrote:
Is dev->gpio (along with this FT260_GPIO feature report read in
ft260_gpio_init()) still needed now that ft260_gpio_set() and
ft260_gpio_direction_set() read FT260_GPIO from the chip before modifying a
pin?
No. v5 removes dev->gpio and the FT260_GPIO read in ft260_gpio_init(),
which only fills it.
Also, FT260_GPIOCHIP and FT260_GPIO_WAKEUP are unused because
ft260_gpio_init() formats dev->gc.label with devm_kasprintf() and checks
enable_wakeup_int with FT260_GPIO_3 directly.
Right. v5 removes both macros.
Thread (27 messages) 27 messages, 4 authors, last reply 1d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help