Re: [PATCH] Input: mt6779-keypad - check the reported row and column

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2026-11-04 23:52:48
Also in
lkml, stable
Reply to
Guanglei Zhu, 2026-11-03
On Tue, Nov 03, 2026 at 04:41:33PM +0800, Guanglei Zhu wrote:
The interrupt handler turns register bits into a matrix position
and indexes the keycode array with it:

		keypad->calc_row_col(key, &row, &col);

		scancode = MATRIX_SCAN_CODE(row, col, row_shift);
		...
		input_report_key(keypad->input_dev, keycode[scancode], pressed);

The keycode array is sized after the rows and columns the device
tree declared, but neither the probe nor the handler checks that a
reported position actually fits those dimensions. A register glitch
or a matrix smaller than the hardware's fixed layout indexes past
the array and reports whatever sits there as a key code.

Skip positions outside the declared matrix.

Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
Cc: <redacted>
Signed-off-by: Guanglei Zhu <redacted>
Applied, thank you.

-- 
Dmitry
Thread (32 messages) 32 messages, 3 authors, last reply 9d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help